??? 05/10/06 19:38 Modified: 05/10/06 19:42 Read: times |
#115959 - I suggest you look at your own changes Responding to: ???'s previous message |
And finally there were comments for the NOP operations. I think there is somebody who knows nothing about driving power transistors and the PWM method. I suggest him to search about these topics.
There never was any argument about the delay only about the implementation. The implementation made the code unreadable and changing to delay loops made it much more readable, while still impossible to decipher due to the lack of comments. To suggest another form for delay while keeping the delay time the same does not by any means indicate "knows nothing about driving power transistors and the PWM method" No comments is a typical beginners mistake ("I know what this does") but try to fix something in this a year later and you WILL be lost. The saying that you have to comment for other people is, of course, true, but what is missing in the statement is that you need - more importantly - to comment for yourself as well. Also, when asking for help, would it be so difficult to answer questions? ACTUAL CHIP. what else I have to say, Steve already said http://www.8052.com/forum/read.phtml?id=115958 Erik |
Topic | Author | Date |
I'm in trouble with my PWM software | 01/01/70 00:00 | |
Interrupts ? | 01/01/70 00:00 | |
Firstly I want to explain how my hardwar | 01/01/70 00:00 | |
89C52 | 01/01/70 00:00 | |
use a uC with a PCA | 01/01/70 00:00 | |
wiggling with the stack pointer | 01/01/70 00:00 | |
I know that.... | 01/01/70 00:00 | |
no you don't | 01/01/70 00:00 | |
To: Erik | 01/01/70 00:00 | |
My code | 01/01/70 00:00 | |
I can't tell | 01/01/70 00:00 | |
His Code | 01/01/70 00:00 | |
Nicely formatted | 01/01/70 00:00 | |
As Erik suggested | 01/01/70 00:00 | |
not valuable | 01/01/70 00:00 | |
Hard to understand | 01/01/70 00:00 | |
asking for? | 01/01/70 00:00 | |
Weird DNA.... | 01/01/70 00:00 | |
that does make a difference | 01/01/70 00:00 | |
Playing with The Stack Pointer | 01/01/70 00:00 | |
Thanks | 01/01/70 00:00 | |
ORG 33H | 01/01/70 00:00 | |
OK | 01/01/70 00:00 | |
replying to what in the above refer to m | 01/01/70 00:00 | |
Listen and learn | 01/01/70 00:00 | |
excellent question | 01/01/70 00:00 | |
I'm listening and learning | 01/01/70 00:00 | |
Oops | 01/01/70 00:00 | |
Rewrite ! | 01/01/70 00:00 | |
WRONG | 01/01/70 00:00 | |
Basic methods & specific details | 01/01/70 00:00 | |
To:Neil | 01/01/70 00:00 | |
+ve&-ve | 01/01/70 00:00 | |
totally unnneded information | 01/01/70 00:00 | |
+ve | 01/01/70 00:00 | |
Me too | 01/01/70 00:00 | |
halfway | 01/01/70 00:00 | |
Just like the first time I saw 3v3 | 01/01/70 00:00 | |
Mid 70's | 01/01/70 00:00 | |
the reason | 01/01/70 00:00 | |
Yes - Very Well Established | 01/01/70 00:00 | |
the trouble is | 01/01/70 00:00 | |
Other calls | 01/01/70 00:00 | |
One thing for the future | 01/01/70 00:00 | |
I do not see the point | 01/01/70 00:00 | |
I got bored... | 01/01/70 00:00 | |
argh, so many nops | 01/01/70 00:00 | |
NOP | 01/01/70 00:00 | |
New version | 01/01/70 00:00 | |
Thanks Steve...and others | 01/01/70 00:00 | |
NO | 01/01/70 00:00 | |
I suggest you look at your own changes | 01/01/70 00:00 | |
His new code | 01/01/70 00:00 | |
very informative | 01/01/70 00:00 | |
Another happy customer | 01/01/70 00:00 | |
Young Double E? | 01/01/70 00:00 | |
finished | 01/01/70 00:00 | |
the one at which end of the body?![]() | 01/01/70 00:00 |