Email: Password: Remember Me | Create Account (Free)

Back to Subject List

Old thread has been locked -- no new posts accepted in this thread
???
03/16/06 11:28
Read: times


 
#112294 - Obscure code...
Responding to: ???'s previous message
Pathipati,

I must say that I thought your method of range checking the buffer indexes is a bit obscure... why do you not just do something like a simple if (index > BUF_SIZE)...
To me it reads easily, I had to really think what your code did and without a bit of thinking, I cannot figure how your receive interrupt code works. Your code also relies on the buffer sizes being nice powers of two in size. Pity you or anyone who has to maintain this code in the future. It's obvious you're using a firebreather of a cpu, so are you trying to save every possible cycle by writing obscure code? Leave that to the people who program PICs in assembler!

The secret to writing defect free code? Don't put the defects in
- keep your code simple and make it read easily.


Jan - great suggestion by using the led. I've been doing that stuff for years, so simple but so many people overlook it.



List of 30 messages in thread
TopicAuthorDate
UART0 interrupt not generating            01/01/70 00:00      
   you never start a timer for the UARTs            01/01/70 00:00      
      i have set it in another init funtion            01/01/70 00:00      
         That sounds fishy, you set SCON0, but            01/01/70 00:00      
   sometimes, you are better off "growing"            01/01/70 00:00      
      i trimmed and tried            01/01/70 00:00      
         get rid of the stupid putchar and what g            01/01/70 00:00      
   config()            01/01/70 00:00      
      but you STILL have the stupid putchar            01/01/70 00:00      
         sorry! complete details now            01/01/70 00:00      
            I will not            01/01/70 00:00      
   further simplified            01/01/70 00:00      
      this is most probably not the root cause            01/01/70 00:00      
         oops            01/01/70 00:00      
            the "printf" of embedded world...            01/01/70 00:00      
               yes LED is flashing            01/01/70 00:00      
                  Obscure code...            01/01/70 00:00      
                     Thank you Russell. At last I completed            01/01/70 00:00      
                        Excellent!            01/01/70 00:00      
                           clarity            01/01/70 00:00      
                        Is it now clear to you what simplificati            01/01/70 00:00      
                        but WHY?????            01/01/70 00:00      
                           the reason            01/01/70 00:00      
                              but, Erik,...            01/01/70 00:00      
                                 You STILL want to know why it is impossi            01/01/70 00:00      
                                    nono, I wouldn't say that            01/01/70 00:00      
                                       and - of course            01/01/70 00:00      
                                          the tool            01/01/70 00:00      
                                             Added to the List            01/01/70 00:00      
   the original problem            01/01/70 00:00      

Back to Subject List